Bug description

The bug occurs when using the on screen buttons to enter guesses, i.e. on a touch screen device or using mouse rather than keyboard. When a guess for a cell is overwritten with pencil marks it doesn't undo any red highlighting that occurred because of the original value in the cell. This happens for both cage goal/operand highlighting and cell highlighting. This doesn't occur if the user changes the focused cell between inputing an incorrect guess and pencil marking over it.

Steps to reproduce

1. Enter a guess in a cell that will trigger red highlighting (of either another cell due to digit uniqueness constraint or the cage goal/operand due to incorrect cage result)
2. Without navigating to another cell activate the pencil mark tool
3. Enter pencil marks in the cell

Video

https://imgur.com/a/PtMiMif

Environment

OS: Mac OS 14.5
Browser: Safari 17.5, Firefox 128.0, Chrome 127.0.6533.100

also

OS: iOS 17.5.1
Browser: Safari




Edit:

I've just found a related bug. In cases where the initial guess is marked red due to digit uniqueness constraints changing it to a pencil mark will red highlight the cage goal/operand even though it was previously unhighlighted.

Video

https://imgur.com/a/PcTG0Nr

many thanks for the detailed report, I'll take a look

this took some digging (ok mostly because I hadn't looked at that code in a while ),
it should work now, let me know

Thanks Patrick that seems to have fixed all the cases I found. I had a further play around and couldn't find any other occurrences.